Skip to content

Conversation

@jmartinesp
Copy link
Contributor

@jmartinesp jmartinesp commented Sep 30, 2024

This seems to be the only way to make the log rotation fix work and avoid build warnings like:

warning: patch for the non root package will be ignored, specify patch at the workspace root:
package:   matrix-rust-sdk/bindings/matrix-sdk-ffi/Cargo.toml
workspace: = matrix-rust-sdk/Cargo.toml
    Finished `dev` profile [unoptimized] target(s) in 0.30s

I can confirm log rotation was working fine on an Android client after these changes, while it's not working with the current code on main.

Fixes the implementation in #4038.

  • Public API changes documented in changelogs (optional)

Signed-off-by:

This seems to be the only way to make the log rotation fix work and avoid build warnings like:

```
warning: patch for the non root package will be ignored, specify patch at the workspace root:
package:   matrix-rust-sdk/bindings/matrix-sdk-ffi/Cargo.toml
workspace: = matrix-rust-sdk/Cargo.toml
    Finished `dev` profile [unoptimized] target(s) in 0.30s
```
@jmartinesp jmartinesp requested a review from a team as a code owner September 30, 2024 06:43
@jmartinesp jmartinesp requested review from bnjbvr and removed request for a team September 30, 2024 06:43
@codecov
Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (ac61fc8) to head (58b8695).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4044      +/-   ##
==========================================
+ Coverage   84.50%   84.51%   +0.01%     
==========================================
  Files         266      266              
  Lines       28512    28512              
==========================================
+ Hits        24093    24098       +5     
+ Misses       4419     4414       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jmartinesp jmartinesp merged commit 743799f into main Sep 30, 2024
@jmartinesp jmartinesp deleted the fix/log-rotation-android-cargo-toml branch September 30, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants