refactor(send queue): refactor in preparation for media local echoes #4176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnjbvr
force-pushed
the
bnjbvr/refactor-queued-events
branch
from
051768a
to
f0b41e3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4176 +/- ##
==========================================
+ Coverage 84.86% 84.89% +0.02%
==========================================
Files 270 271 +1
Lines 29031 29035 +4
==========================================
+ Hits 24637 24648 +11
+ Misses 4394 4387 -7 ☔ View full report in Codecov by Sentry. |
|
Wait, a rename of serialized JSON field names is a breaking change, since the field name is encoded next to the value, IIRC. Will have to do the sqlite migration here too \o/ |
|
bnjbvr
force-pushed
the
bnjbvr/refactor-queued-events
branch
from
f0b41e3
to
acf9081
Compare
bnjbvr
requested review from
a team and
andybalaam
and removed request for
a team
andybalaam
approved these changes
Oct 29, 2024
…` to `load_dependent_send_queue_events`
…d_queue module No changes in functionality, only code motion.
In a next commit, the `QueuedEvent` will be renamed to `QueuedRequest`. This specifies which kind of request we want to send with the send queue; for now, it can only be an event.
Changelog: Renamed all the send-queue related "events" to "requests", so as to generalize usage of the send queue to not-events (e.g. medias, redactions, etc.).
bnjbvr
force-pushed
the
bnjbvr/refactor-queued-events
branch
from
acf9081
to
acf79a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactors the send queue so that it can apply sending more abstract requests, instead of only sending plain events. This will generalize to media uploads soon, but in the future might also generalize to sending redactions, etc. So we now queue requests, update requests, and so on; which leads to some fun renaming in a massive patch, but no changes in functionality. Those would come in subsequent pull requests.
Indexeddb has a database format change, that is gently handled the same way we did for is_wedged vs wedged errors, that is: the migration applies at the reading boundary (we can't use the
#[serde(untagged)]enum trick because we're storing a raw JSON value, and this is known to be buggy in serde). Sqlite hasn't been modified yet.Part of #1732.