Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): A bit of code moving in event_cache #4178

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Oct 28, 2024

This patch renames event_cache/store.rs to event_cache/room/events.rs, and extract types about RoomEventCache from event_cache/mod.rs to event_cache/room/mod.rs. I hope it clarifies things.

It's purely code moves, no renaming, no other changes.

@Hywan Hywan requested a review from a team as a code owner October 28, 2024 16:24
@Hywan Hywan requested review from poljar and removed request for a team October 28, 2024 16:24
@bnjbvr bnjbvr requested review from bnjbvr and removed request for poljar October 28, 2024 16:25
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There are some unit tests that would require some code motion too, please :-)

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 91.16022% with 16 lines in your changes missing coverage. Please review.

Project coverage is 84.79%. Comparing base (77b3aa8) to head (b775df2).
Report is 27 commits behind head on main.

Files with missing lines Patch % Lines
crates/matrix-sdk/src/event_cache/room/mod.rs 91.16% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4178      +/-   ##
==========================================
- Coverage   84.82%   84.79%   -0.04%     
==========================================
  Files         269      270       +1     
  Lines       28963    28961       -2     
==========================================
- Hits        24569    24558      -11     
- Misses       4394     4403       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan requested a review from bnjbvr October 29, 2024 09:11
@Hywan
Copy link
Member Author

Hywan commented Oct 29, 2024

Indeed! Tests have been moved accordingly.

@Hywan Hywan merged commit 6752cf7 into matrix-org:main Oct 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants