fix(pinned_events): get pinned event ids from the HS as fallback #4205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4205 +/- ##
==========================================
+ Coverage 84.87% 84.90% +0.02%
==========================================
Files 272 272
Lines 29125 29143 +18
==========================================
+ Hits 24720 24744 +24
+ Misses 4405 4399 -6 ☔ View full report in Codecov by Sentry. |
Hywan
reviewed
Nov 4, 2024
Hywan
approved these changes
Nov 4, 2024
|
I had to fix the tests separately 😅 . Will merge once the tests are green. |
…n't contain it This should take care of a bug that caused pinned events to be incorrectly removed when the new pinned event ids list was based on an empty one if the required state of the room didn't contain any pinned events info
jmartinesp
force-pushed
the
fix/get-pinned-events-from-hs-if-not-found-in-sync
branch
from
7e82a24
to
72a0ea6
Compare
jmartinesp
deleted the
fix/get-pinned-events-from-hs-if-not-found-in-sync
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the required state of a room doesn't contain pinned events info for some reason, try using the
/stateendpoint from the HS to get this data instead.This should take care of a bug that caused pinned events to be incorrectly removed when the new pinned event ids list was based on an empty one if the required state of the room didn't contain any pinned events info
Signed-off-by: