fix(timeline): update responses after a UTD has been decrypted #4210
Conversation
|
|
||
| let first_item_again = | ||
| assert_next_matches!(stream, VectorDiff::Set { index: 0, value } => value); | ||
| assert_matches!(first_item_again.content(), TimelineItemContent::RedactedMessage); | ||
| assert_matches!(first_item_again.original_json(), None); |
There was a problem hiding this comment.
The order of the assertion is changed here, because now we update the responses before the original event. This avoids a copy in the timeline code 👀 . You would be right calling this a code smell and asking for a change here, as I didn't bother too much (observers wouldn't notice a big difference).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4210 +/- ##
==========================================
+ Coverage 84.88% 84.90% +0.02%
==========================================
Files 272 272
Lines 29133 29125 -8
==========================================
Hits 24730 24730
+ Misses 4403 4395 -8 ☔ View full report in Codecov by Sentry. |
| @@ -1190,8 +1190,34 @@ impl<'a, 'o> TimelineEventHandler<'a, 'o> { | |||
| } | |||
| } | |||
|
|
|||
| Flow::Remote { position: TimelineItemPosition::Update(idx), .. } => { | |||
| Flow::Remote { | |||
| event_id: decrypted_event_id, | |||
There was a problem hiding this comment.
Not really part of this PR but, oh boy, I feel like this could express that this is an UTD -> Decrypted transition a bit better.
Flow::Remote is generally for remote echoes and TimlineItemPosition::Update does not sound UTD specific at all.
There was a problem hiding this comment.
Good idea to rename this Update; will do in a follow-up, thanks!
bnjbvr
force-pushed
the
bnjbvr/update-response-after-successful-decryption
branch
from
f8b231a
to
2665ea3
Compare
Fixes #4196.