refactor!(room list): remove unneeded argument from RoomList::entries_with_dynamic_adapters
#4214
+9
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s_with_dynamic_adapters` Changelog: the parameter `room_info_notable_update_receiver` was removed from `RoomList::entries_with_dynamic_adapters`, since it could be inferred internally instead.
Hywan
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4214 +/- ##
=======================================
Coverage 84.88% 84.89%
=======================================
Files 272 272
Lines 29166 29167 +1
=======================================
+ Hits 24757 24760 +3
+ Misses 4409 4407 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameter
room_info_notable_update_receiverwas removedfrom
RoomList::entries_with_dynamic_adapters, since it could beinferred internally instead.
Alternative to #4212, which I think avoids the problem altogether by providing a better API.