Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Move linked chunk into matrix-sdk-common and few event cache types into matrix-sdk-base #4247

Conversation

Hywan
Copy link
Member

@Hywan Hywan commented Nov 11, 2024

In order to implement the event cache persistent storage for events, we need some types from matrix_sdk::event_cache inside matrix_sdk_base, and we need linked_chunk inside matrix_sdk_common.

First off, this patch renames matrix-sdk-base/src/event_cache_store to matrix-sdk-base/src/event_cache/store. Second, it moves linked_chunk inside matrix-sdk-common. And lastly, it moves 2 event cache types into matrix-sdk-base.

That's it folks.


@Hywan Hywan requested a review from a team as a code owner November 11, 2024 16:11
@Hywan Hywan requested review from poljar and removed request for a team November 11, 2024 16:11
@Hywan Hywan force-pushed the refactor-event-cache-move-some-types-to-matrix-sdk-base branch from d1808ee to 8c12288 Compare November 11, 2024 16:19
@Hywan Hywan marked this pull request as draft November 11, 2024 16:33
@Hywan Hywan force-pushed the refactor-event-cache-move-some-types-to-matrix-sdk-base branch from 8c12288 to 9c1bec3 Compare November 13, 2024 11:00
@Hywan Hywan force-pushed the refactor-event-cache-move-some-types-to-matrix-sdk-base branch from 9c1bec3 to 181eb62 Compare November 13, 2024 11:10
@Hywan Hywan changed the title refactor(sdk,base): Move some linked chunk types into matrix-sdk-base refactor(sdk,base): Move linked chunk into matrix-sdk-common and few event cache types into matrix-sdk-base Nov 13, 2024
@Hywan Hywan changed the title refactor(sdk,base): Move linked chunk into matrix-sdk-common and few event cache types into matrix-sdk-base refactor: Move linked chunk into matrix-sdk-common and few event cache types into matrix-sdk-base Nov 13, 2024
@Hywan Hywan marked this pull request as ready for review November 13, 2024 11:13
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.93%. Comparing base (403be3d) to head (181eb62).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4247   +/-   ##
=======================================
  Coverage   84.93%   84.93%           
=======================================
  Files         274      274           
  Lines       29726    29728    +2     
=======================================
+ Hits        25247    25249    +2     
  Misses       4479     4479           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hywan Hywan merged commit aca83fb into matrix-org:main Nov 13, 2024
62 of 77 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants