chore: Downgrade xshell due to broken stdin interactions #4376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since xshell 0.2.3 the behavior of the run() function has changed in a incompatible manner. Namely the stdin for the run() function no longer inherits stdin from the shell. This makes it impossible for commands that are executed by the run() function to accept input from the shell. We don't use this functionality in many places but the `xtask release prepare` command is now broken. Let's just pin xshell to a working version while we wait for this to be resolved upstream. Upstream-issue: matklad/xshell#63
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
=======================================
Coverage 85.13% 85.13%
=======================================
Files 280 280
Lines 30802 30802
=======================================
+ Hits 26222 26223 +1
+ Misses 4580 4579 -1 ☔ View full report in Codecov by Sentry. |
bnjbvr
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since xshell 0.2.3 the behavior of the run() function has changed in a incompatible manner. Namely the stdin for the run() function no longer inherits stdin from the shell. This makes it impossible for commands that are executed by the run() function to accept input from the shell.
We don't use this functionality in many places but the
xtask release preparecommand is now broken.Let's just pin xshell to a working version while we wait for this to be resolved upstream.
Upstream-issue: matklad/xshell#63