feat(crypto-ffi-bindings): Save/Load dehydrated pickle key #4399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillCarsonFr
commented
Dec 10, 2024
BillCarsonFr
changed the base branch from
main
to
valere/cache_dehydration_pickle_key
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4399 +/- ##
==========================================
- Coverage 85.32% 85.31% -0.01%
==========================================
Files 283 283
Lines 31442 31452 +10
==========================================
+ Hits 26827 26834 +7
- Misses 4615 4618 +3 ☔ View full report in Codecov by Sentry. |
BillCarsonFr
force-pushed
the
valere/ffi_save_store_dehydration_pickle_key
branch
from
8550edb to
57e3421
Compare
BillCarsonFr
force-pushed
the
valere/cache_dehydration_pickle_key
branch
from
604e379 to
2b39476
Compare
BillCarsonFr
force-pushed
the
valere/ffi_save_store_dehydration_pickle_key
branch
from
57e3421 to
39b9531
Compare
BillCarsonFr
commented
Dec 13, 2024
andybalaam
approved these changes
Dec 16, 2024
| use crate::DehydratedDeviceKey; | ||
|
|
||
| #[test] | ||
| fn test_dehydrated_key() { |
There was a problem hiding this comment.
How about test_creating_dehydrated_key_from_slice ?
There was a problem hiding this comment.
Or test_roundtrip_dehydrated_device_key maybe
review: better tests
BillCarsonFr
force-pushed
the
valere/ffi_save_store_dehydration_pickle_key
branch
from
39b9531 to
95582a6
Compare
BillCarsonFr
deleted the
valere/ffi_save_store_dehydration_pickle_key
branch
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft because depends on #4383
Signed-off-by: