crypto: extra logging in OtherUserIdentity
#4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
requested review from
jmartinesp and
andybalaam
and removed request for
a team
richvdh
commented
Dec 13, 2024
| @@ -392,6 +392,7 @@ impl OtherUserIdentity { | |||
|
|
|||
| /// Pin the current identity (public part of the master signing key). | |||
| pub async fn pin_current_master_key(&self) -> Result<(), CryptoStoreError> { | |||
| info!(master_key = ?self.master_key.get_first_key(), "Pinning current identity for user '{}'", self.user_id()); | |||
There was a problem hiding this comment.
Sample output (on Element web):
INFO matrix_sdk_crypto::identities::user: Pinning current identity for user '@g:xps9320.sw1v.org'
master_key=Some("ed25519:pKj/3plhPwWMRhfe0F5CzrPk3RHzU0BPxBb/QpL0kNs")
at /home/rav/work/matrix-rust-sdk/crates/matrix-sdk-crypto/src/identities/user.rs:395
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4415 +/- ##
==========================================
- Coverage 85.31% 85.30% -0.01%
==========================================
Files 282 282
Lines 31259 31261 +2
==========================================
Hits 26668 26668
- Misses 4591 4593 +2 ☔ View full report in Codecov by Sentry. |
jmartinesp
approved these changes
Dec 16, 2024
It's someone else's cross-signing key, so by definition, a public key. |
auto-merge was automatically disabled
December 16, 2024 11:28
Rebase failed
Add some extra logging in these two methids, to try to narrow down a bug report we received.
richvdh
force-pushed
the
rav/identity_pin_logging
branch
from
23e189a to
ed1178c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some extra logging in these two methods, to try to narrow down a bug report
we received.