Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5012 +/- ##
==========================================
- Coverage 85.87% 85.85% -0.02%
==========================================
Files 325 325
Lines 35853 35856 +3
==========================================
- Hits 30787 30784 -3
- Misses 5066 5072 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| /// Set a generic login hint to help an identity provider pre-fill the login | ||
| /// form. | ||
| /// | ||
| /// Note: This is not the same as the [`Self::user_id_hint()`] method, which | ||
| /// is specifically designed to a) take a `UserId` and no other type of | ||
| /// hint and b) be used directly by MAS and not the identity provider. |
There was a problem hiding this comment.
Hmm, this overwrites whatever we set with user_id_hint(), we should mention this.
Out of interest, what will you set as the hint?
There was a problem hiding this comment.
Good point, I've added the same The following methods are mutually exclusive line that we use in the client builder.
It will likely be an email address but it depends on the upstream provider, we would pass through whatever is given to us without modifying it. The use case is an organisation creating provisioning links like https://app.example.com/?server_name=example.org&login_hint=alice where their upstream provider knows how to handle alice as a hint.
There are docs here: https://openid.net/specs/openid-connect-core-1_0.html#AuthRequest
There was a problem hiding this comment.
Ah makes sense. Can we perhaps more explicitly mention this example use-case and link to these docs?
780d349 to
2c92db5
Compare
|
Ah, the CI isn't happy yet. |
|
I don't understand what the failure is: |
|
Ah seems like this is hitting other PRs and the fix is here: |
|
Thanks a lot for that and the corresponding bits in MAS, you beat us to it by a week or 2 I believe :) |
This PR makes 2 changes:
login_hintmethod to the OAuth URL builder (see Forward thelogin_hintupstream. element-hq/matrix-authentication-service#4512 for more context).login_hinton the FFI'surl_for_oidcmethod.