-
Notifications
You must be signed in to change notification settings - Fork 342
feat(oauth): add flow for granting login by scanning a QR code #5818
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
673b011 to
c7d6032
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5818 +/- ##
==========================================
+ Coverage 88.54% 88.60% +0.05%
==========================================
Files 361 361
Lines 101533 102140 +607
Branches 101533 102140 +607
==========================================
+ Hits 89904 90502 +598
- Misses 7418 7419 +1
- Partials 4211 4219 +8 ☔ View full report in Codecov by Sentry. |
|
@poljar I'm really sorry for the onslaught of tedious PRs around QR login. I think after this one there is, luckily, only one left for the bindings to grant login which should hopefully be small. |
CodSpeed Performance ReportMerging #5818 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks mostly good. I found a couple of nits.
No worries about the amount of QR code PRs and sorry for the delay on this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks good.
Let's just get rid of the fixup commits.
Signed-off-by: Johannes Marbach <[email protected]>
…enerate for better usability and to match the login flow Signed-off-by: Johannes Marbach <[email protected]>
…lower value for tests to speed them up Signed-off-by: Johannes Marbach <[email protected]>
…ibe_to_progress Signed-off-by: Johannes Marbach <[email protected]>
…r_code to avoid future name clashes for the opposite flow Signed-off-by: Johannes Marbach <[email protected]>
Signed-off-by: Johannes Marbach <[email protected]>
81d3f61 to
488c3f5
Compare
|
History is clean now. |
This is a follow-up on #5801 and adds the opposite flow where the existing device scans the QR code generated on the new device.
I have tried to break this down into commits as far as seemed feasible. Unfortunately, git has made a bit off a mess out of the diff for the test cases in the last commit. It might be easier to review that part by looking at the whole file. The commit only adds entirely new test cases.