Remove references to device-specific push rules. #1842
+213
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still has a dangling reference to "Push Rulesets" (see https://pr1842--matrix-spec-previews.netlify.app/client-server-api/#push-notifications), unsure how to rephrase that. But the push rule account data event still includes it so, maybe just leave it. |
richvdh
reviewed
Jun 11, 2024
richvdh
reviewed
Jun 18, 2024
| examples: | ||
| response: | ||
| value: { | ||
| "content": [ |
There was a problem hiding this comment.
I believe, if we move this example to definitions/push_ruleset.yaml, it will magically be used for both endpoints, without the need to duplicate it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove references to device-specific push rules, which have never been implemented and aren't really specified.
This might need an MSC, but #637 is marked as a clarification so I wasn't sure. 🤷
Fix #637
Preview: https://pr1842--matrix-spec-previews.netlify.app