Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ExportedSessionKey conversion trait for SessionKey #114

Closed

Conversation

Michael-Hollister
Copy link

@Michael-Hollister Michael-Hollister commented Oct 2, 2023

Added helper conversion trait for MSC3061 implementation. See following PR for more details: matrix-org/matrix-rust-sdk#2650

Signed-off-by: Michael Hollister [email protected]

Copy link
Collaborator

@poljar poljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that this makes much sense, happy to be convinced otherwise though.

src/megolm/session_keys.rs Show resolved Hide resolved
@poljar
Copy link
Collaborator

poljar commented Oct 4, 2023

As discussed, we have a dedicated method to create an InboundGroupSession from the ExportedSessionKey. Converting from a SessionKey to a ExportedSessionKey loses some data which we don't want to encourage.

@poljar poljar closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants