feat: support InPlaceUpdate when only configuration changes are made #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberchen98
force-pushed
the
wangchen/inplace-update
branch
from
686d721 to
c14cd2f
Compare
cyberchen98
force-pushed
the
wangchen/inplace-update
branch
from
270d964 to
abae4ed
Compare
aylei
reviewed
Oct 16, 2024
pkg/webhook/proxy_webhook.go
Outdated
| @@ -53,6 +54,7 @@ func (p *proxySetDefaulter) Default(_ context.Context, obj runtime.Object) error | |||
|
|
|||
| func (p *proxySetDefaulter) DefaultSpec(spec *v1alpha1.ProxySetSpec) { | |||
| setDefaultServiceArgs(spec) | |||
| spec.OperatorVersion = pointer.String(v1alpha1.LatestOpVersion.String()) | |||
There was a problem hiding this comment.
defaulting op version will cause rolling-update accidentally
There was a problem hiding this comment.
only set OperatorVersion when it's empty, or distinguish CREATE/UPDATE and only set on CREATE
aylei
reviewed
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
Fixes #
What this PR does / why we need it:
https://github.com/matrixorigin/MO-Cloud/issues/4026
Special notes for your reviewer:
Not Available
Additional documentation (e.g. design docs, usage docs, etc.):
Not Available