remove unused fields in s3writer #20844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ouyuanning
requested review from
m-schen,
aunjgr,
badboynt1 and
qingxinhome
as code owners
badboynt1
approved these changes
Dec 19, 2024
m-schen
approved these changes
Dec 19, 2024
qingxinhome
approved these changes
Dec 19, 2024
aunjgr
approved these changes
Dec 19, 2024
zhangxu19830126
approved these changes
Dec 20, 2024
ouyuanning
added a commit
to ouyuanning/matrixone
that referenced
this pull request
Dec 20, 2024
remove unused fields in s3writer Approved by: @badboynt1, @m-schen, @qingxinhome, @aunjgr, @zhangxu19830126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #20834
What this PR does / why we need it:
remove unused fields in s3writer