Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parallel branch length optimization #28

Merged
merged 18 commits into from
Jun 5, 2024
Merged

parallel branch length optimization #28

merged 18 commits into from
Jun 5, 2024

Conversation

matsen
Copy link
Contributor

@matsen matsen commented Jun 2, 2024

  • implementing parallel branch length optimization
  • storing datasets rather than loaders (makes more sense; pickleable)
  • facility to split data set
  • using AdamW optimizer
  • dropping verbose due to lr_on_plateau no longer supporting it
  • walltime since start of execution time
  • ignore UserWarning from torch.nn.modules.transformer

@matsen matsen linked an issue Jun 2, 2024 that may be closed by this pull request
@matsen matsen marked this pull request as ready for review June 3, 2024 10:01
Copy link

@mmjohn mmjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Is this the reason for the switch from torch.optim.Adam() to torch.optim.AdamW()? https://stackoverflow.com/questions/64621585/adamw-and-adam-with-weight-decay

@matsen
Copy link
Contributor Author

matsen commented Jun 3, 2024

Yes, exactly.

@matsen matsen merged commit c48a52f into main Jun 5, 2024
1 check passed
@matsen matsen deleted the 27-parallel-bl branch June 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parallel branch length optimization
2 participants