Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't record loss before training, which fixes incorrect logging #53

Merged
merged 1 commit into from
Sep 9, 2024
Merged

don't record loss before training, which fixes incorrect logging #53

merged 1 commit into from
Sep 9, 2024

Conversation

matsen
Copy link
Contributor

@matsen matsen commented Sep 9, 2024

The line

   train_loss = self.process_data_loader(train_loader, train_mode=False).item()

was causing some train loss to be recorded as a val loss.

@matsen matsen merged commit a708d6a into main Sep 9, 2024
1 check passed
@matsen matsen deleted the 51-logging branch September 9, 2024 12:46
@matsen matsen linked an issue Sep 9, 2024 that may be closed by this pull request
Fix incorrect logging of train loss as val loss once per optimization cycle #51
Closed
@matsen matsen mentioned this pull request Sep 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix incorrect logging of train loss as val loss once per optimization cycle
1 participant
@matsen