-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate the multihit model into the DNSM framework #71
Conversation
Add multihit model in a few more places make format fix shape issue fix rebase issue, but tests still fail force_spawn in tests reformat switch to serial branch length optimization multihit works with threading WIP-- nothing works now comment test+fake multihit working re-enable multihit perhaps working, fixed device mismatch and switched to nonlog correction application I think this might have worked verified working here cleanup for PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small things here to fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two last nitpicks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR replaces #60, and is a companion to https://github.com/matsengrp/dnsm-experiments-1/pull/29