Add image handling and dimension parsing to renderer #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added new binary file `blake.png`. - Enhanced `ImageCaptionRenderer` with regex support for parsing shorthand dimensions from image URLs. - Updated class definition to `public partial` and added a static readonly field for regex. - Modified `Write` method to apply shorthand dimensions if no explicit width/height attributes are present. - Introduced `ParseShorthandDimensions` method for dimension extraction and `HtmlEscape` method for safe HTML encoding.
github-actions
bot
added
preview
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ImageCaptionRenderer class to support shorthand dimension syntax in image URLs, allowing users to specify image dimensions directly in the URL (e.g., "/image.png =200x300") instead of requiring explicit HTML attributes.
Key changes:
- Added regex-based parsing for shorthand dimensions in image URLs
- Enhanced the renderer to automatically apply parsed dimensions as HTML attributes when explicit dimensions aren't provided
- Converted the class to use source-generated regex for better performance
matt-goldman
added
release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
blake.png.ImageCaptionRendererwith regex support for parsing shorthand dimensions from image URLs.public partialand added a static readonly field for regex.Writemethod to apply shorthand dimensions if no explicit width/height attributes are present.ParseShorthandDimensionsmethod for dimension extraction andHtmlEscapemethod for safe HTML encoding.🧷 This PR will be released as a preview by default.
To trigger a stable release:
previewlabelreleaselabelSemver-MinororSemver-Majorto control version bump🏷️ Add labels to control release notes:
enhancement,bug,breaking-change,dependenciesignore-for-releaseto suppress it from notes