Improved error handling for bulk indexing to provide more information… #219
+373
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the error channel
|
Btw, this would fix #198 |
|
do you mind rebasing @gburgett? I'm trying to get as many of these out of the way so we can focus on the breaking change PR's that are still pending. |
|
I merged the fixes to the race condition in the bulk indexer and you will need to merge your changes again. @gburgett |
|
Thanks, unfortunately I'm no longer a member of the Concur organization. @ryan-bunker should be able to finish out this pull request. |
added 3 commits
October 12, 2015 15:18
…t, until they are fully sent and any errors are reported, to ensure proper shutdown sequencing
# Conflicts: # lib/baserequest.go # lib/corebulk.go # lib/corebulk_test.go # lib/coreexample_test.go # lib/coretest_test.go # lib/request.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been trying to use the bulk indexer in an app we're writing, and we're finding that we need to be more intelligent about error handling. For instance, in our setup we point the app at a load balancer which redirects to our Elasticsearch nodes. If all nodes are down we get a 503 with some html, and the elastigo library returns this as a json parsing error.
I've put in some improvements for better error handling, and a unit test which more closely demonstrates our need.