Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetUrl - DEFLATE support, embed AuthnRequest in AuthnSignedRequest #9

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

owen
Copy link
Contributor

@owen owen commented Dec 9, 2015

Here's a new round of changes that make this work more nicely with Shibboleth servers. Highlights:

  • All methods now take a binding method that allows the binding type to be changed. I've tested this against HTTP-POST and HTTP-Redirect so far.
  • GetRequestUrl() now deflates the data before base64 & URLEncode. This is needed per the spec.
  • I've embedded an AuthnRequest inside AuthnSignedRequest, which simplified things quite a bit.

You may not want to merge these - I've changed the signatures on some of those functions. I'm not sure if I'm happy with that or not... I might poke at this a bit more to see if I can keep the API from changing.

* GetRequestUrl(int) now takes a int of the binding and doesn't assume
  Redirect.
* BindingPOST was changed to capitalize POST
* ACSIndex is now omitempty
@owen
Copy link
Contributor Author

owen commented Dec 10, 2015

I'm still thinking about how to keep the existing API as is. if anyone has thoughts, I'd be happy to hack them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant