Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose MakePath function #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bsnchan
Copy link

@bsnchan bsnchan commented Apr 26, 2018

Signed-off-by: Dave Protasowski [email protected]

Signed-off-by: Dave Protasowski <[email protected]>
@mattbaird
Copy link
Owner

Why do you want to expose this function?

@dprotaso
Copy link

We've encountered a scenario where we have an existing path and want to append a new part. This new part has a / which should be encoded to ~1.

We saw the function and figured exporting it would be useful.

@bsnchan
Copy link
Author

bsnchan commented Apr 30, 2018

@mattbaird any thoughts on this?

@dprotaso
Copy link

Hey @mattbaird do you have any other questions?

@dprotaso
Copy link

@mattbaird Any updates?

@mattbaird
Copy link
Owner

Folks - I am so sorry. I had a "startup moment" where I had to go dark for quite some time.

Can you rebase so I can merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants