ci: let the fork build the Windows canary installer - #25
Merged
Conversation
The Scalarly team has a Windows user and there is no signed Windows release for this fork, so the unsigned NSIS canary artifact is the only Windows shipping path we have. The job's `github.repository == 'block/buzz'` guard skipped it here. Everything else about the workflow already works for us unchanged: `tauri.windows.conf.json` drops `buzz-backend-kubernetes` from `externalBin` (matching `bundle-sidecars.sh`, which skips it on Windows), and `updater.endpoints: []` on our `tauri.conf.json` plus the canary config's `createUpdaterArtifacts: false` mean the build can never self-update back to an unpatched upstream release.
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A teammate is on Windows. This fork has no signed Windows release, so the unsigned NSIS canary artifact is the shipping path — same posture as the ad-hoc-signed macOS dmg we already hand out. The
Windows Canaryjob was gated ongithub.repository == 'block/buzz', so it skipped onmattbalza/buzzand produced nothing.What changed
One line: the job guard now admits both
block/buzzandmattbalza/buzz.Why nothing else needs changing
desktop/src-tauri/tauri.windows.conf.jsonalready overridesexternalBindown to five sidecars (nobuzz-backend-kubernetes), matchingscripts/bundle-sidecars.sh, which skips that crate on*windows*targets. The basetauri.conf.jsonlists six — Tauri validatesexternalBinat compile time, so the platform override is what makes the Windows bundle resolvable.tauri.conf.jsonshipsupdater.endpoints: []and the workflow's generated canary config setscreateUpdaterArtifacts: false. A teammate's Windows build can't be replaced by an unpatched upstream release.cargo update --workspacein the version-patch step re-resolves workspace members only — it does not bump third-party crates, so no supply-chain surface.mesh-llmon Windows, matching upstream's ownrelease-windowsjob. We don't use the local model mesh.Test plan
workflow_dispatchonmainafter merge (the workflow'sRequire mainstep enforces that), then:Build Windows NSIS installer (unsigned)instead of skipping.Upload Windows canary installerproducesbuzz-windows-canary-<sha>containing one.exe.wss://buzz.scalarly.org, and confirm@erp/@codex/@claude/@seekreach mention autocomplete — the same four-linkchannelIdschain the macOS build was gated on.