Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken Dockerfile fix #5017

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DanArmor
Copy link

Changed go image version according to updated dependencies in commit c8e729b

Summary

Right now Dockerfile is broken, because c8e729b bumped golang version to 1.21, but in Dockerfile 1.18 is used for build. go.mod file is using toolchain keyword, that was introduced in 1.21 - it leads into broken build:

Screenshot_20240617_213212

Solution: updated version of the golang in Dockerfile to 1.21.8@sha256:856073656d1a517517792e6cdd2f7a5ef080d3ca2dff33e518c8412f140fdd2d

After that change build is working:
Screenshot_20240617_215953

Ticket Link

No ticket

Changed go image version according to updated dependencies
@mattermost-build
Copy link
Contributor

Hello @DanArmor,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@DanArmor
Copy link
Author

Encountered another error on startup, right after build
Screenshot_20240617_222132

Changed go image version to golang:1.21.8-bullseye@sha256:81d98548f08e22a59c5c0be814acc0997f3dfd3313487adcf4e1d3d962af3a43
Screenshot_20240617_222925

Now it works

@mattermost-build
Copy link
Contributor

This PR has been automatically labelled "stale" because it hasn't had recent activity.
A core team member will check in on the status of the PR to help with questions.
Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants