Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed mattermost-plugin folder #5029

Merged
merged 13 commits into from
Aug 28, 2024

Conversation

Rajat-Dabade
Copy link
Contributor

@Rajat-Dabade Rajat-Dabade commented Jul 29, 2024

Removed mattermost-plugin folder from the repo as it was not required.

Stacked on: #5027

@Rajat-Dabade Rajat-Dabade added the 2: Dev Review Requires review by a core committer label Jul 29, 2024
@Rajat-Dabade Rajat-Dabade self-assigned this Jul 29, 2024
@Rajat-Dabade Rajat-Dabade changed the base branch from main to deprecate-isplugin-code July 29, 2024 11:27
@Rajat-Dabade Rajat-Dabade added the Do Not Merge Should not be merged until this label is removed label Jul 30, 2024
@harshilsharma63
Copy link
Member

@Rajat-Dabade some CI checks are failing.

@Rajat-Dabade
Copy link
Contributor Author

Rajat-Dabade commented Jul 30, 2024

@harshilsharma63, these issues have been resolved as part of this PR: #5031, which is stacked on this PR.

Once they are merged into this PR, these CI tests will be fixed.

Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slightly satisfying.

@Rajat-Dabade Rajat-Dabade removed the Do Not Merge Should not be merged until this label is removed label Aug 21, 2024
Rajat-Dabade and others added 12 commits August 28, 2024 09:10
* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test (#5031)

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: updated the mac-os version supported by github actions

* reverted: mac os version

* refactor: updated mac os version and also changed docker-compose to docker compose
* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: removed isplugin code from server
@toninis toninis force-pushed the remove-mattermost-plugin-layer branch from b227bc9 to af696ab Compare August 28, 2024 06:11
@Rajat-Dabade Rajat-Dabade merged commit 613fd19 into deprecate-isplugin-code Aug 28, 2024
9 checks passed
@Rajat-Dabade Rajat-Dabade deleted the remove-mattermost-plugin-layer branch August 28, 2024 15:53
Rajat-Dabade added a commit that referenced this pull request Aug 28, 2024
* refactor: updated mysql docker image version

* refactor: removed isPlugin code from webapp

* refactor: removed isFocalboardPlugin from test

* refactor: removed package-lock.json from root

* removed unnecessary component

* nit: removed comments

* reverted the mysql docker version to original

* nit

* revert setting.json changes

* Removed `mattermost-plugin` folder (#5029)

* refactor: removed mattermost-plugin folder

* reverted the mysql image version

* Removed `mattermost-plugin` from make rules (#5030)

* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test (#5031)

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: updated the mac-os version supported by github actions

* reverted: mac os version

* refactor: updated mac os version and also changed docker-compose to docker compose

* removed version from docker compose as no long needed

* reverted mysql docker version

* updated mysql version

* testing

* revert testing

* refactor: added version for mysql docker compose file

* test: test commit

* updated snapshot and fix test (#5032)

* removed mattermost-plugin from make rules

* removed: mattermost-plugin code from the repo

* updated snapshot and fix test

* Updated snapshot and removed unnecessary tests

* chore: minor fix ci

* refactor: removed isplugin code from server

* final attempt

* ci: Minor ci tweaks and upgrades

---------

Co-authored-by: Antonis Stamatiou <[email protected]>

* linter fixes

---------

Co-authored-by: Antonis Stamatiou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2: Dev Review Requires review by a core committer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants