-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed mattermost-plugin
folder
#5029
Merged
Rajat-Dabade
merged 13 commits into
deprecate-isplugin-code
from
remove-mattermost-plugin-layer
Aug 28, 2024
Merged
Removed mattermost-plugin
folder
#5029
Rajat-Dabade
merged 13 commits into
deprecate-isplugin-code
from
remove-mattermost-plugin-layer
Aug 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rajat-Dabade
added
the
Do Not Merge
Should not be merged until this label is removed
label
Jul 30, 2024
harshilsharma63
approved these changes
Jul 30, 2024
@Rajat-Dabade some CI checks are failing. |
@harshilsharma63, these issues have been resolved as part of this PR: #5031, which is stacked on this PR. Once they are merged into this PR, these CI tests will be fixed. |
sbishel
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly satisfying.
Rajat-Dabade
removed
the
Do Not Merge
Should not be merged until this label is removed
label
Aug 21, 2024
* removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test (#5031) * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: updated the mac-os version supported by github actions * reverted: mac os version * refactor: updated mac os version and also changed docker-compose to docker compose
* removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: removed isplugin code from server
toninis
force-pushed
the
remove-mattermost-plugin-layer
branch
from
August 28, 2024 06:11
b227bc9
to
af696ab
Compare
Rajat-Dabade
added a commit
that referenced
this pull request
Aug 28, 2024
* refactor: updated mysql docker image version * refactor: removed isPlugin code from webapp * refactor: removed isFocalboardPlugin from test * refactor: removed package-lock.json from root * removed unnecessary component * nit: removed comments * reverted the mysql docker version to original * nit * revert setting.json changes * Removed `mattermost-plugin` folder (#5029) * refactor: removed mattermost-plugin folder * reverted the mysql image version * Removed `mattermost-plugin` from make rules (#5030) * removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test (#5031) * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: updated the mac-os version supported by github actions * reverted: mac os version * refactor: updated mac os version and also changed docker-compose to docker compose * removed version from docker compose as no long needed * reverted mysql docker version * updated mysql version * testing * revert testing * refactor: added version for mysql docker compose file * test: test commit * updated snapshot and fix test (#5032) * removed mattermost-plugin from make rules * removed: mattermost-plugin code from the repo * updated snapshot and fix test * Updated snapshot and removed unnecessary tests * chore: minor fix ci * refactor: removed isplugin code from server * final attempt * ci: Minor ci tweaks and upgrades --------- Co-authored-by: Antonis Stamatiou <[email protected]> * linter fixes --------- Co-authored-by: Antonis Stamatiou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
mattermost-plugin
folder from the repo as it was not required.Stacked on: #5027