Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-4843] Deletes newly created card after close if no interaction were made in #5041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jav974
Copy link

@jav974 jav974 commented Oct 2, 2024

Summary

After creating a new card, if user does not type into any field or interact with any of the different options and closes the dialog, the card gets removed immediately.

Ticket Link

Fixes #4843

@mattermost-build
Copy link
Contributor

Hello @jav974,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@jav974
Copy link
Author

jav974 commented Oct 2, 2024

The implementation differs from the discussion on the ticket, in that the card gets created serverside as usual, but it gets removed if the modal is closed and no interaction were made.
The card is not destroyed if user types something in a field, then deletes it, or adds a new property (even empty) or attachment.

/claim #4843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Empty cards are created when no changes are made
2 participants