Skip to content

Bump version to v1.2.0#21

Merged
jfrerich merged 2 commits intomasterfrom
bump-version-v1.2.0
Mar 23, 2020
Merged

Bump version to v1.2.0#21
jfrerich merged 2 commits intomasterfrom
bump-version-v1.2.0

Conversation

@jfrerich
Copy link
Copy Markdown
Contributor

@jfrerich jfrerich commented Feb 6, 2020 •
edited
Loading

Summary

Bump version to v1.2.0

Proposal to bump Minor Version to prep for release with the following Release Notes:

Enhancements

Fixes

Ticket Link

https://mattermost.atlassian.net/browse/MM-22266

@jfrerich jfrerich added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Feb 6, 2020
@jfrerich jfrerich added the 1: PM Review Requires review by a product manager label Feb 6, 2020
@marianunez
Copy link
Copy Markdown
Contributor

marianunez commented Feb 6, 2020

@jfrerich this release requires Mattermost v5.20 that is not yet released. Just wanted to double check that we are OK we having this out first.

@levb levb added the Do Not Merge Should not be merged until this label is removed label Feb 6, 2020
@hanzei
Copy link
Copy Markdown
Contributor

hanzei commented Feb 6, 2020

We can even put in the Marketplace right now. The code logic makes sure it it not shown for servers < v5.20.

@marianunez marianunez removed the 2: Dev Review Requires review by a core committer label Feb 6, 2020
@levb levb removed the Do Not Merge Should not be merged until this label is removed label Feb 7, 2020
@jfrerich
Copy link
Copy Markdown
Contributor Author

jfrerich commented Feb 7, 2020

Sounds like we are ready to merge after remaining review. Thanks for added info, @hanzei

@levb
Copy link
Copy Markdown
Contributor

levb commented Feb 7, 2020

Sounds like we are ready to merge after remaining review. Thanks for added info, @hanzei

Just be careful not to push to community, until after community.mattermost.com is on 5.20 (2/17/2020)

@jfrerich jfrerich added the Do Not Merge Should not be merged until this label is removed label Feb 11, 2020
aaronrothschild
aaronrothschild approved these changes Feb 12, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@aaronrothschild aaronrothschild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, love the new interface. Will miss wonky config.json setups....not.

@aaronrothschild aaronrothschild removed the 1: PM Review Requires review by a product manager label Feb 12, 2020
@hanzei hanzei removed the Do Not Merge Should not be merged until this label is removed label Feb 20, 2020
@DHaussermann
Copy link
Copy Markdown

DHaussermann commented Feb 28, 2020

Version bump was successful and End to End testing is now done.

@aaronrothschild please advise if we have time to fix
#22 before we ship this release.

@aaronrothschild
Copy link
Copy Markdown
Contributor

aaronrothschild commented Feb 28, 2020

@jfrerich Can you fix the oddly formatted "delete" icon before we merge? I think we need to add 45 degrees tilt... not much risk involved I'm assuming. ;)

@hanzei hanzei added this to the v1.2.0 milestone Mar 6, 2020
@DHaussermann
Copy link
Copy Markdown

DHaussermann commented Mar 6, 2020

This is waiting on #23 so we can include it in the release.

@jfrerich jfrerich added the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Mar 10, 2020
@levb levb removed the Do Not Merge/Awaiting PR Awaiting another pull request before merging (e.g. server changes) label Mar 19, 2020
@jfrerich
Copy link
Copy Markdown
Contributor Author

jfrerich commented Mar 19, 2020

@DHaussermann, #23 has been merged! Can you do a quick review of this ticket?

@DHaussermann
Copy link
Copy Markdown

DHaussermann commented Mar 19, 2020

@jfrerich this won't have the fix for #23
Not a huge problem. I can approve the version bump anyway but, should we sync from master first.

@hanzei
Copy link
Copy Markdown
Contributor

hanzei commented Mar 19, 2020

/update-branch

@jfrerich
Copy link
Copy Markdown
Contributor Author

jfrerich commented Mar 19, 2020

@dylan, master has been merged.

@DHaussermann
Copy link
Copy Markdown

DHaussermann commented Mar 20, 2020

  • End 2 End testing completed
  • Version bump was successful
  • No issues found

This is a great improvement! However, the new admin UI does not seem to be documented in the read-me. @marianunez or @aaronrothschild please advise on next steps.

@marianunez
Copy link
Copy Markdown
Contributor

marianunez commented Mar 22, 2020

@DHaussermann agreed that the new configuration screen should be documented in the Readme. I suggest that we open a ticket for it but I unfortunately do not have bandwith to complete it at this time.

1/5 it should be included before releasing 1.2.0

@jfrerich jfrerich mentioned this pull request Mar 23, 2020
Closed
@jfrerich
Copy link
Copy Markdown
Contributor Author

jfrerich commented Mar 23, 2020

@marianunez, I'll add to the README and added this ticket. #30

As a side note, @levb and I discussed READMEs and attaching them to the actual bumped release.

  • README.md changes aren’t necessarily vital.
  • Documentation isn't viewable through the app and users will be looking at the latest master commit in the github repo. So, although the README is necessary, it can be done post merge in some cases. I'l

@marianunez
Copy link
Copy Markdown
Contributor

marianunez commented Mar 23, 2020

Sound good @jfrerich! Thanks!

@jfrerich
Copy link
Copy Markdown
Contributor Author

jfrerich commented Mar 23, 2020

@DHaussermann I created a ticket for the README. Merging this now.

@jfrerich jfrerich merged commit e51b382 into master Mar 23, 2020
@jfrerich jfrerich deleted the bump-version-v1.2.0 branch March 23, 2020 17:43
@jfrerich jfrerich self-assigned this Mar 24, 2020
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marianunez marianunez marianunez approved these changes

@DHaussermann DHaussermann Awaiting requested review from DHaussermann

+2 more reviewers

@aaronrothschild aaronrothschild aaronrothschild approved these changes

@levb levb levb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jfrerich jfrerich

Labels

4: Reviews Complete All reviewers have approved the pull request

Projects

None yet

Milestone

v1.2.0

Development

Successfully merging this pull request may close these issues.

8 participants

@jfrerich @marianunez @hanzei @levb @DHaussermann @aaronrothschild @jwilander @mattermod