Fixes #67. Replaced empty string with empty array

[coltoneshaw]

Fixes #67.

Just replaced the empty string with an empty array. Tested and the config.json file saves / parses properly on restarting mattermost.

[hanzei]

Good catch 👍

[DHaussermann]

@coltoneshaw strangely, I still see this behavior occurring.

• Build Custom Attributes from this branch and deploy
• Enable Custom Attributes
• Add a record that has no Group ID and save
• Disable the plugin
• Enable the plugin
  Observed Server logs still show {"timestamp":"2021-10-14 10:33:43.063 -04:00","level":"debug","msg":"2021/10/14 10:33:43 LoadPluginConfiguration API failed to unmarshal: json: cannot unmarshal string into Go struct field CustomAttribute.CustomAttributes.GroupIDs of type []string","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.mattermost.custom-attributes"}

Maybe I missed something can you please see if you can reproduce this on the PR branch as well?

[dipak-demansol]

@coltoneshaw strangely, I still see this behavior occurring.

• Build Custom Attributes from this branch and deploy
• Enable Custom Attributes
• Add a record that has no Group ID and save
• Disable the plugin
• Enable the plugin
  Observed Server logs still show {"timestamp":"2021-10-14 10:33:43.063 -04:00","level":"debug","msg":"2021/10/14 10:33:43 LoadPluginConfiguration API failed to unmarshal: json: cannot unmarshal string into Go struct field CustomAttribute.CustomAttributes.GroupIDs of type []string","caller":"plugin/hclog_adapter.go:54","plugin_id":"com.mattermost.custom-attributes"}

Maybe I missed something can you please see if you can reproduce this on the PR branch as well?

Hi Dylan, i tested with Master +patch1 branch & master + patch + coltoneshaw:groupIdfixes and the error was not generated, LGTM.

[dipak-demansol]

LGTM

[hanzei]

@DHaussermann Can we merge this?

[DHaussermann]

/update-branch

[DHaussermann]

@hanzei can we please leave this open for a couple more days. @dipak-demansol and I are seeing different results on this and are working to find the cause of the deployment issue.

[coltoneshaw]

@DHaussermann , are you testing this with a fresh plugin, or did you have the old version. IIRC you may need to update the config.json to fix the original issue and then test. Or remove the plugin along with its config and test with the new version.

[DHaussermann]

Thanks @coltoneshaw I can rip all pre-existing data out of my config or try this on a fresh server.

[DHaussermann]

After doing another round of testing this PR is good to merge.

• After testing this with the config in a fresh state - I see that the error with .json unmarshall is resolved which is the scope of this PR. This can now be merged.

• The issue I was seeing was that Team names cannot be retrieved and is unrelated. Furthermore, the issue also occurs in the master branch. I have created Unable to add Team selection to a custom attribute #76 to address it.

• FWIW the deployment issue @dipak-demansol and were seeing seems to have been caused by differences in the main.js in the webapp folder of the plugin. Having the same mattermost/mattermost-webapp on the same more current build hash resolved this discrepancy and confirmed the issue is valid.

[DHaussermann]

Tested ands passed

As per testing above the issue is resolved.

LGTM!