Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-232] Update plugin with respect to phase 1 upgrades #96

Merged
merged 2 commits into from
Apr 23, 2024
Merged

[MM-232] Update plugin with respect to phase 1 upgrades #96

merged 2 commits into from
Apr 23, 2024

Conversation

ayusht2810
Copy link
Contributor

Summary

Updated plugin with respect to phase 1 upgrades

  • Updated go version from 1.12 to 1.21
  • Updated build folder to sync with starter template
  • Updated package in go modules to use https://pkg.go.dev/github.com/mattermost/mattermost/server/public
  • Updated Makefile
  • Updated version in nvmrc file and update package-lock.json file.
  • Added base setup for typescript
  • Added base setup for test cases
  • Fix lint errors
  • Updated developer docs link in the readme file

Ticket Link

@marianunez marianunez requested review from mickmister and removed request for marianunez February 20, 2024 20:29
mickmister
mickmister reviewed Mar 14, 2024
View reviewed changes
Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one suggestion

webapp/src/components/widgets/confirmation_modal.tsx Outdated Show resolved Hide resolved
@mickmister mickmister merged commit 7c107f1 into mattermost-community:master Apr 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ayusht2810 @mickmister @Kshitij-Katiyar