Use GetUsersInChannel instead of getUsers #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
approved these changes
Sep 20, 2024
|
@BenCookie95 As discussed, I tested this PR with the same org members in MM, but still the issue remains the same. Mentioning issue number here #2 . Can you please take a look at this? |
wiggin77
approved these changes
Oct 2, 2024
@BenCookie95 Did you get a chance to look at this? |
@AayushChaudhary0001 I did, this PR rectifies the issue of adding members who are not in the channel. The issue you are seeing is more permission related and is separate. I'm working on another fix for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
GetUsers does not work as intended, use GetUsersInChannel instead
Ticket
#21