Cherry-pick (#214) into release-2.0 #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* go get -u golang.org/x/sys * Fix CI * Add App Bar icon * Fix errors found by linter * Allow arrow functions in eslint's func-style rule * fix type mismatch at redux Provider Co-authored-by: Ngoan Tran <[email protected]>
agarciamontoro
added
2: Dev Review
|
@agarciamontoro I'm struggling to build this PR branch. With node 16 npm fetch goes for a very long time and then ends with... Can you provide a build or some troubleshooting ideas? :) |
larkox
approved these changes
Jun 17, 2022
| @@ -12,6 +12,14 @@ type Props = { | |||
| children: React.ReactNode, | |||
| } | |||
|
|
|||
| export class InjectionProvider extends React.Component<any> { | |||
iomodo
approved these changes
Jun 17, 2022
|
@DHaussermann, build is also failing on CI. Let me check 🙏 |
|
Closing per https://community-daily.mattermost.com/core/pl/cix75ceit3neff7fgacyoo7uth, with the follow up being to release a new version off of master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
release-2.0branch has been created from thev2.0.0tag. This PR cherry-picks #214 into that branch, so we can release a new v2.1.0 with only this change.Ticket Link
--