[MM-54367] Apply scope to the menu class (#213)

* apply scope to the menu class * change error message * remove unused classnames * fix lint
mattermost-community · Sep 28, 2023 · 1aa947c · 1aa947c
1 parent a309a7a
commit 1aa947c
Show file tree

Hide file tree

Showing 6 changed files with 9 additions and 10 deletions.
diff --git a/server/command.go b/server/command.go
@@ -102,7 +102,7 @@ func (p *Plugin) postCommandResponse(args *model.CommandArgs, text string) {
 }
 
 // ExecuteCommand executes a given command and returns a command response.
-func (p *Plugin) ExecuteCommand(c *plugin.Context, args *model.CommandArgs) (*model.CommandResponse, *model.AppError) {
+func (p *Plugin) ExecuteCommand(_ *plugin.Context, args *model.CommandArgs) (*model.CommandResponse, *model.AppError) {
 	spaceRegExp := regexp.MustCompile(`\s+`)
 	trimmedArgs := spaceRegExp.ReplaceAllString(strings.TrimSpace(args.Command), " ")
 	stringArgs := strings.Split(trimmedArgs, " ")
@@ -287,7 +287,7 @@ func (p *Plugin) runListCommand(args []string, extra *model.CommandArgs) (bool,
 	return false, nil
 }
 
-func (p *Plugin) runPopCommand(args []string, extra *model.CommandArgs) (bool, error) {
+func (p *Plugin) runPopCommand(_ []string, extra *model.CommandArgs) (bool, error) {
 	issue, foreignID, err := p.listManager.PopIssue(extra.UserId)
 	if err != nil {
 		if err.Error() == "cannot find issue" {

diff --git a/server/plugin.go b/server/plugin.go
@@ -130,7 +130,7 @@ func (p *Plugin) initializeAPI() {
 }
 
 // ServeHTTP demonstrates a plugin that handles HTTP requests by greeting the world.
-func (p *Plugin) ServeHTTP(c *plugin.Context, w http.ResponseWriter, r *http.Request) {
+func (p *Plugin) ServeHTTP(_ *plugin.Context, w http.ResponseWriter, r *http.Request) {
 	w.Header().Set("Content-Type", "application/json")
 
 	p.router.ServeHTTP(w, r)

diff --git a/webapp/src/widget/menu.scss b/webapp/src/widget/menu.scss
@@ -1,10 +1,10 @@
 .status-dropdown-menu {
-    > .Menu {
+    > .TodoMenu {
         position: inherit;
     }
 }
 
-.Menu {
+.TodoMenu {
     display: flex;
     flex-direction: column;
     position: absolute;
@@ -125,8 +125,7 @@
     }
 }
 
-.Menu,
-.SubMenuOption .SubMenu {
+.TodoMenu {
     @media screen and (max-width: 430px) {
         position: fixed;
         top: 0;

diff --git a/webapp/src/widget/menu.tsx b/webapp/src/widget/menu.tsx
@@ -19,7 +19,7 @@ export default class Menu extends React.PureComponent<Props> {
 
         return (
             <div
-                className={'Menu noselect ' + (position || 'bottom')}
+                className={'TodoMenu noselect ' + (position || 'bottom')}
                 tabIndex={0}
             >
                 <div className='menu-contents'>

diff --git a/webapp/src/widget/menuWrapper.scss b/webapp/src/widget/menuWrapper.scss
@@ -1,4 +1,4 @@
-.MenuWrapper {
+.TodoMenuWrapper {
     position: relative;
 
     &.disabled {

diff --git a/webapp/src/widget/menuWrapper.tsx b/webapp/src/widget/menuWrapper.tsx
@@ -76,7 +76,7 @@ const MenuWrapper = React.memo((props: Props) => {
     }, []);
 
     const {children} = props;
-    let className = 'MenuWrapper';
+    let className = 'TodoMenuWrapper';
     if (props.disabled) {
         className += ' disabled';
     }