Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CODEOWNERS #237

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Remove CODEOWNERS #237

merged 4 commits into from
Nov 17, 2023

Conversation

larkox
Copy link
Contributor

@larkox larkox commented Nov 17, 2023

Summary

I don't actively maintain this plugin anymore, and many things are happening that I am completely detached from, so I guess it is better if I get removed from the codeowners.

That way is more clear when a review from my side is looked for, or just added as a codeowner, and avoid noise or waiting on your side.

Ticket Link

NONE

@larkox larkox added the 2: Dev Review Requires review by a core committer label Nov 17, 2023
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you also want to remove yourself from the README?

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b25f12) 6.42% compared to head (c501437) 6.42%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #237   +/-   ##
======================================
  Coverage    6.42%   6.42%           
======================================
  Files          11      11           
  Lines        1712    1712           
======================================
  Hits          110     110           
  Misses       1594    1594           
  Partials        8       8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@larkox
Copy link
Contributor Author

larkox commented Nov 17, 2023

@hanzei There is already an open PR for that (#227). I can do it also here, but 0/5.

@hanzei
Copy link
Contributor

hanzei commented Nov 17, 2023

1/5 let's do that as part of this PR

@larkox larkox requested a review from hanzei November 17, 2023 11:02
@mickmister
Copy link
Contributor

I don't want community PRs that come in to be missed at everything's current state. Sort of a "dead tarzan" if we simply remove the CODEOWNERS file. @hanzei Thoughts on putting that on me for now?

@mickmister mickmister merged commit 1afeeb0 into master Nov 17, 2023
@mickmister mickmister deleted the removeCodeOwners branch November 17, 2023 23:24
@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Nov 20, 2023
@avas27JTG avas27JTG added this to the v1.0.0 milestone Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants