Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect examples in bindings docs page #1317

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Conversation

ghost
Copy link

@ghost ghost commented Dec 7, 2023

Added correction in the bindings docs to solve the call function issue.

Addresses: mattermost/docs#6821

Added correction to incorrect examples in binding docs
@mattermost-build
Copy link
Contributor

Hello @rohan-kapse,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@ghost ghost changed the title Update _index.md Incorrect examples in bindings docs page Dec 8, 2023
@cwarnermm cwarnermm requested a review from mickmister December 8, 2023 18:18
@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Dec 8, 2023
@cwarnermm cwarnermm requested a review from hanzei December 8, 2023 18:19
@ghost
Copy link
Author

ghost commented Dec 11, 2023

@hanzei Kindly take a look at the PR and let me know.

@mickmister
Copy link
Contributor

Thanks for this contribution @rohan-kapse!

@mickmister mickmister added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Dec 14, 2023
@mickmister
Copy link
Contributor

@hanzei I think this is good to merge, though needs two approvals

@hanzei hanzei merged commit 1fa2e07 into mattermost:master Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants