Skip to content

MM-68540: Drop redundant user_id from refresh WS payload#1004

Merged
nang2049 merged 1 commit intomasterfrom
MM-68540-followup-empty-refresh-payload
May 6, 2026
Merged

MM-68540: Drop redundant user_id from refresh WS payload#1004
nang2049 merged 1 commit intomasterfrom
MM-68540-followup-empty-refresh-payload

Conversation

@nang2049
Copy link
Copy Markdown
Contributor

@nang2049 nang2049 commented May 6, 2026

Summary

Followup to #1002. The WS event is purely a doorbell now and the recipient is already targeted by WebsocketBroadcast.UserId and the webapp handler doesn't read msg.data. Sending user_id was both unused
and unnecessary.

@nang2049 nang2049 requested a review from lieut-data May 6, 2026 14:20
@nang2049 nang2049 requested a review from a team as a code owner May 6, 2026 14:20
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 6, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 42a8aef1-fdc3-49f0-97b4-164845c906eb

📥 Commits

Reviewing files that changed from the base of the PR and between fb313de and 4a2412a.

📒 Files selected for processing (1)
  • server/plugin/plugin.go

📝 Walkthrough

Walkthrough

The PublishWebSocketEvent call within sendRefreshEvent is modified to publish a nil payload instead of a map containing user_id. This is a single-line payload alteration in the WebSocket event publishing logic.

Changes

WebSocket Event Payload Simplification

Layer / File(s) Summary
Event Publishing
server/plugin/plugin.go
sendRefreshEvent now publishes the refresh event with a nil payload instead of a map containing user_id.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A payload once carried a user's delight,
Now nil flows swift through the WebSocket's night,
One line refined, the event still shines bright,
Simpler it goes, and that feels so right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: removing a redundant user_id field from a WebSocket event payload, which aligns perfectly with the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch MM-68540-followup-empty-refresh-payload

Comment @coderabbitai help to get the list of available commands and usage tips.

@nang2049 nang2049 requested a review from avasconcelos114 May 6, 2026 14:33
@nang2049 nang2049 merged commit 5e32dfe into master May 6, 2026
19 checks passed
@nang2049 nang2049 deleted the MM-68540-followup-empty-refresh-payload branch May 6, 2026 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants