MM-68540: Drop redundant user_id from refresh WS payload#1004
MM-68540: Drop redundant user_id from refresh WS payload#1004
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PublishWebSocketEvent call within sendRefreshEvent is modified to publish a nil payload instead of a map containing user_id. This is a single-line payload alteration in the WebSocket event publishing logic. ChangesWebSocket Event Payload Simplification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Summary
Followup to #1002. The WS event is purely a doorbell now and the recipient is already targeted by WebsocketBroadcast.UserId and the webapp handler doesn't read msg.data. Sending user_id was both unused
and unnecessary.