Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when plugin bundle is too large #195

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Feb 9, 2024

Summary

Downstream mattermost/mattermost#25842

Ticket Link

Fixes #194

@hanzei hanzei added the 2: Dev Review Requires review by a core committer label Feb 9, 2024
@hanzei hanzei requested a review from mickmister February 9, 2024 16:22
@hanzei hanzei self-assigned this Feb 9, 2024
@mickmister
Copy link
Contributor

@hanzei Nothing really to QA test in the starter template. Is this god to merge?

@hanzei hanzei added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Feb 12, 2024
@hanzei
Copy link
Contributor Author

hanzei commented Feb 12, 2024

Yes, I think so

@hanzei hanzei merged commit 495541e into master Feb 12, 2024
6 checks passed
@hanzei hanzei deleted the MM-56455_apperror-from-json branch February 12, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Basic plugin builds artifacts larger than 50MB, the common max upload size on default Mattermost setups
2 participants