Add support for batched templated emails #6
Conversation
Arttii
changed the title
|
Hi Arttii, Thanks so much - and apologies for my slow response - I don't know how I missed this. I've left a couple of comments, but the biggest issue would be around the error handling for this endpoint. From Postmark docs:
The pkg currently isn't setup to handle errors that return a 200-level response, so some adjustments will be needed so errors can be returned correctly from your new method. Thanks! |
| @@ -100,3 +101,27 @@ func (s *EmailService) SendBatch(emailRequests []*Email) ([]*EmailResponse, *Res | |||
|
|
|||
| return email, response, nil | |||
| } | |||
|
|
|||
| // SendBatchTemplated will build and execute request to send batch templated emails via the API. | |||
| func (s *EmailService) SendBatchTemplated(emailRequests []*Email) ([]*EmailResponse, *Response, error) { | |||
There was a problem hiding this comment.
Could we perhaps rename to something more in alignment with postmark?
SendBatchWithTemplates perhaps?
| var formatEmails map[string]interface{} = map[string]interface{}{ | ||
| "Messages": emailRequests, | ||
| } |
There was a problem hiding this comment.
| var formatEmails map[string]interface{} = map[string]interface{}{ | |
| "Messages": emailRequests, | |
| } | |
| formatEmails := map[string]interface{}{ | |
| "Messages": emailRequests, | |
| } |
| } | ||
|
|
||
| email := []*EmailResponse{} | ||
| response, err := s.client.Do(request, email) |
There was a problem hiding this comment.
See comment left on PR. But the tldr; is we will never get an error back here due to this endpoint always returning 200.
|
Any updates on this? |
Hi,
I need to be able to send batches of templates as well, so I added another function to take care of it.
Feedback is welcome
Thank!