Skip to content

Conversation

lothartj
Copy link

No description provided.

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: bc642bd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
robot3 Major
haunted-robot Major
preact-robot Major
lit-robot Major
react-robot Major
robot-hooks Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lothartj
Copy link
Author

Hey there! Just went through the invoke.md file and honestly, it's looking pretty solid as is! 👍
The documentation already has everything we need:
Super clear explanation of what invoke does with async operations
Really helpful examples showing how to use Promises properly (including what NOT to do - always good to know!)
Nice section on child machines and how they work
Clear breakdown of events like 'done' and 'error'
Some solid best practices for error handling and cleanup
Good info about cancellation (even though JS Promises can't really be cancelled)
I took a look to see if there was anything to improve, but it's already well-organized and easy to follow. Sometimes good documentation is just... good documentation! 😊
Want me to take a look at any other files where we might be able to make some meaningful improvements?

@matthewp
Copy link
Owner

I'm a little confused, you did adjust some of the documentation, but also made a major change, that i don't think actually changes anything concretely. What are you going for here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants