Display metadata group undefined in the ruleset

Fixes kitodo#3762
matthias-ronge · Jun 18, 2020 · 229dd97 · 229dd97
1 parent 702c69c
commit 229dd97
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessTextMetadata.java b/Kitodo/src/main/java/org/kitodo/production/forms/createprocess/ProcessTextMetadata.java
@@ -105,6 +105,9 @@ Pair<Method, Object> getStructureFieldValue() throws InvalidMetadataValueExcepti
 
     @Override
     public boolean isValid() {
+        if (Objects.isNull(settings)) {
+            return false;
+        }
         if (Objects.isNull(value) || value.isEmpty()) {
             return false;
         }

diff --git a/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/DataEditorForm.java b/Kitodo/src/main/java/org/kitodo/production/forms/dataeditor/DataEditorForm.java
@@ -733,6 +733,9 @@ public String getReferringView() {
      * @return whether the given ProcessDetail can be added or not
      */
     public boolean canBeAdded(ProcessDetail processDetail) {
+        if (!processDetail.isValid()) {
+            return false;
+        }
         if (Objects.nonNull(this.getAddDocStrucTypeDialog().getSelectAddableMetadataTypesItems())) {
             return this.getAddDocStrucTypeDialog().getSelectAddableMetadataTypesItems().stream()
                     .map(SelectItem::getValue).collect(Collectors.toList()).contains(processDetail.getMetadataID());