fix: terminate ssh option parsing before the dispatch target - #394
Merged
Merged
Conversation
A target beginning with a dash reached ssh as an option. The remote-control bridge already passes `--` before its target; the composer dispatch now does the same. Also records why the local machine list is truncated to one entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ssh_argvinsrc/app/machines.rsplaced the dispatch target directly after its-oflags, so a target that begins with a dash reached ssh as an option rather than a destination.src/remote/control.rs:132already passes--before its target; the composer dispatch now matches it.Also records why
resolvetruncates the local machine list to one entry: a fleet may declare several local hosts, and only the first becomes the local entry before the remotes are appended.Verification: 6
machinestests pass, including a new assertion that the target sits immediately after--.just check-parallelis otherwise clean;cases::agents::agent_start_command_worksfailed once under parallel load and passes in isolation (14.0s), and touches no file in this diff.https://claude.ai/code/session_01A1fNC92h5X4aeBB2aYBxv1