Skip to content

fix: rank blocking closing gates above external waits - #396

Merged
matthias-scale merged 1 commit into
mainfrom
fix/closing-gates-outrank-waits
Sep 24, 2026
Merged

matthias-scale merged 1 commit into
mainfrom
fix/closing-gates-outrank-waits

Conversation

@matthias-scale

Copy link
Copy Markdown
Owner

A pane whose closing block had blocking gates plus a Waiting: line reported working, so the sidebar hid a real blocker (ub1 wG:p6, arbitration closing_external_wait, 3 gates, idle screen).

Changes

  • Hook (closing_block.py herdr_state, herdr_status.py state_for): blocking gates and Waiting-on-you rank above external waits and running agents.
  • Server (closing_task_projection): pending human input on a non-working screen projects Blocked before the external-wait branch.
  • _EXTERNAL_WAIT_RE / _WAITING_ON_YOU_RE: a wait also ends at . Waiting on you / ; waiting on you, so the tail is no longer swallowed into the wait text.

Evidence

Corpus: 13,227 closing blocks from 14 days of Claude/Codex transcripts on ub1, ub2, mbpro.

  • 871 had gates plus a wait and reported working; the next human turn answered them at a rate close to plain gates (41% vs 61%), versus 13% for wait-only blocks.
  • Replay of the ub2 corpus through the new parser: gates+wait 221 → all blocked (was all working); swallowed wait tails 53 → 1; wait-only blocks stay working.

Tests

  • Python closing-block suite: 120 OK (new fixtures from observed lines).
  • Rust: pending_human_input_outranks_external_wait_on_an_idle_screen.
  • Updated old-precedence tests: test_report_emits_v2_arrays_and_blocked_channel_with_agents, test_non_gate_action_points_block_even_when_an_agent_is_running, test_report_emits_lifecycle_fields_while_blocked_by_human_input.
  • Worker ran full Rust, lint, maintenance and integration checks green on ub2; Windows cross-check not run (no SDK config on ub2).

https://claude.ai/code/session_01TmcjGzo6LrkTRHph3f241E

@matthias-scale matthias-scale added the claimed:cl-528cf8e6 Herdr PR claim label label Sep 24, 2026
@matthias-scale
matthias-scale merged commit 92df280 into main Sep 24, 2026
10 of 11 checks passed
@matthias-scale
matthias-scale deleted the fix/closing-gates-outrank-waits branch September 24, 2026 05:18
matthias-scale added a commit that referenced this pull request Sep 24, 2026
Cold-cache runs finish right at the 15-minute limit and get cancelled
in the last step (#396, #399).

Claude-Session: https://claude.ai/code/session_01TmcjGzo6LrkTRHph3f241E
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

claimed:cl-528cf8e6 Herdr PR claim label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant