Set up ESLint for the repo and fix lint issues

.editorconfig

@@ -0,0 +1,21 @@
+# http://editorconfig.org
+
+root = true
+
+[*]
+charset = utf-8
+end_of_line = lf
+indent_style = space
+insert_final_newline = true
+trim_trailing_whitespace = true
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false
+
+[*.py]
+indent_size = 4
+
+[Makefile]
+indent_style = tabs
+indent_size = 2

.prettierignore

@@ -11,4 +11,5 @@ build
 vite.config.ts.timestamp*
 *.d.ts
 *.gen.ts
-**/evalite-export
+**/evalite-export
+.astro

apps/evalite-ui/app/components/page-layout.tsx

@@ -3,7 +3,6 @@ import {
   BreadcrumbItem,
   BreadcrumbLink,
   BreadcrumbList,
-  BreadcrumbPage,
 } from "./ui/breadcrumb";
 import { Separator } from "./ui/separator";
 import { SidebarTrigger } from "./ui/sidebar";

apps/evalite-ui/app/components/ui/copy-button.tsx

@@ -2,11 +2,6 @@ import * as React from "react";
 import { CopyIcon, CheckIcon } from "lucide-react";
 import { cn } from "~/lib/utils";
 import { Button } from "~/components/ui/button";
-import {
-  Tooltip,
-  TooltipContent,
-  TooltipTrigger,
-} from "~/components/ui/tooltip";
 
 interface CopyButtonProps
   extends React.ButtonHTMLAttributes<HTMLButtonElement> {

apps/evalite-ui/app/components/ui/line-chart.tsx

@@ -54,16 +54,7 @@ export function MyLineChart(props: {
           type="linear"
           className="--var"
           strokeWidth={1}
-          activeDot={({
-            points,
-            payload,
-            height,
-            width,
-            className,
-            dataKey,
-            key,
-            ...dotProps
-          }) => {
+          activeDot={({ payload, key, ...dotProps }) => {
             const onClick = () => {
               props.onDotClick({ date: payload.date });
             };

apps/evalite-ui/app/routes/__root.tsx

@@ -3,7 +3,6 @@ import {
   queryOptions,
   useQueryClient,
   useSuspenseQueries,
-  useSuspenseQuery,
 } from "@tanstack/react-query";
 import { ReactQueryDevtools } from "@tanstack/react-query-devtools";
 import {
@@ -32,7 +31,6 @@ import {
   getServerStateQueryOptions,
 } from "~/data/queries";
 import { useSubscribeToSocket } from "~/data/use-subscribe-to-socket";
-import { useServerStateUtils } from "~/hooks/use-server-state-utils";
 import "../tailwind.css";
 
 const TanStackRouterDevtools =
@@ -125,7 +123,6 @@ export default function App() {
     {
       data: { groupedEvals, score, prevScore, evalStatus, hasScores },
     },
-    { data: serverState },
   ] = useSuspenseQueries({
     queries: [getMenuItemsWithSelect, getServerStateQueryOptions],
   });
@@ -169,7 +166,7 @@ export default function App() {
           <SidebarGroup>
             <SidebarGroupLabel>Evals</SidebarGroupLabel>
             <SidebarMenu>
-              {groupedEvals.map((item, idx) => {
+              {groupedEvals.map((item) => {
                 if (item.type === "single") {
                   return (
                     <EvalSidebarItem

apps/evalite-ui/app/routes/eval.$name.result.$resultIndex.tsx

@@ -25,7 +25,6 @@ import {
   getResultQueryOptions,
   getServerStateQueryOptions,
 } from "~/data/queries";
-import { useServerStateUtils } from "~/hooks/use-server-state-utils";
 
 const searchSchema = z.object({
   trace: z.number().optional(),
@@ -91,7 +90,6 @@ function ResultComponent() {
     {
       data: { result, prevResult, evaluation },
     },
-    { data: serverState },
   ] = useSuspenseQueries({
     queries: [
       getResultQueryOptions({
@@ -102,11 +100,6 @@ function ResultComponent() {
       getServerStateQueryOptions,
     ],
   });
-  const serverStateUtils = useServerStateUtils(serverState);
-
-  const isRunning =
-    serverStateUtils.isRunningEvalName(name) &&
-    evaluation.created_at === timestamp;
 
   const startTime = result.traces[0]?.start_time ?? 0;
   const endTime = result.traces[result.traces.length - 1]?.end_time ?? 0;

apps/evalite-ui/eslint.config.js

@@ -1,28 +1,23 @@
-import js from "@eslint/js";
+import { defineConfig } from "eslint/config";
 import globals from "globals";
 import reactHooks from "eslint-plugin-react-hooks";
 import reactRefresh from "eslint-plugin-react-refresh";
-import tseslint from "typescript-eslint";
+import rootConfig from "../../eslint.config.js";
 
-export default tseslint.config(
-  { ignores: ["dist"] },
-  {
-    extends: [js.configs.recommended, ...tseslint.configs.recommended],
-    files: ["**/*.{ts,tsx}"],
-    languageOptions: {
-      ecmaVersion: 2020,
-      globals: globals.browser,
-    },
-    plugins: {
-      "react-hooks": reactHooks,
-      "react-refresh": reactRefresh,
-    },
-    rules: {
-      ...reactHooks.configs.recommended.rules,
-      "react-refresh/only-export-components": [
-        "warn",
-        { allowConstantExport: true },
-      ],
-    },
-  }
-);
+export default defineConfig(...rootConfig, {
+  files: ["**/*.{ts,tsx}"],
+  languageOptions: {
+    globals: globals.browser,
+  },
+  plugins: {
+    "react-hooks": reactHooks,
+    "react-refresh": reactRefresh,
+  },
+  rules: {
+    ...reactHooks.configs.recommended.rules,
+    "react-refresh/only-export-components": [
+      "warn",
+      { allowConstantExport: true },
+    ],
+  },
+});

apps/evalite-ui/package.json

@@ -7,7 +7,8 @@
     "build": "vite build",
     "after-build": "rm -rf ../../packages/evalite/dist/ui && cp -r dist ../../packages/evalite/dist/ui",
     "dev": "vite",
-    "lint": "tsr generate && tsc",
+    "typecheck": "tsr generate && tsc --noEmit",
+    "lint": "eslint .",
     "test": "vitest run"
   },
   "dependencies": {
@@ -48,16 +49,10 @@
     "@tanstack/router-plugin": "^1.117.0",
     "@types/react": "19.2.0",
     "@types/react-dom": "19.2.0",
-    "@typescript-eslint/eslint-plugin": "^6.7.4",
-    "@typescript-eslint/parser": "^6.7.4",
     "@vitejs/plugin-react": "^4.3.4",
     "autoprefixer": "^10.4.19",
-    "eslint": "^8.38.0",
-    "eslint-import-resolver-typescript": "^3.6.1",
-    "eslint-plugin-import": "^2.28.1",
-    "eslint-plugin-jsx-a11y": "^6.7.1",
-    "eslint-plugin-react": "^7.33.2",
-    "eslint-plugin-react-hooks": "^4.6.0",
+    "eslint-plugin-react-hooks": "^7.0.1",
+    "eslint-plugin-react-refresh": "^0.4.24",
     "tailwindcss": "^4.1.11",
     "tw-animate-css": "^1.3.5",
     "typescript": "5.9.3",

eslint.config.js

@@ -0,0 +1,41 @@
+import js from "@eslint/js";
+import { defineConfig } from "eslint/config";
+import globals from "globals";
+import tseslint from "typescript-eslint";
+
+export default defineConfig(
+  {
+    ignores: [
+      "**/dist/**",
+      "**/.evalite/**",
+      "**/evalite.db",
+      "apps/evalite-docs/.astro/**",
+      "apps/evalite-docs/src/env.d.ts",
+    ],
+  },
+  js.configs.recommended,
+  ...tseslint.configs.recommended,
+  {
+    files: ["**/*.{ts,tsx,mts,cts}"],
+    languageOptions: {
+      ecmaVersion: 2022,
+      globals: {
+        ...globals.node,
+        ...globals.es2022,
+      },
+    },
+    rules: {
+      "@typescript-eslint/no-explicit-any": "off",
+      "@typescript-eslint/no-unused-vars": [
+        "error",
+        {
+          argsIgnorePattern: "^_",
+          varsIgnorePattern: "^_",
+        },
+      ],
+      "@typescript-eslint/no-namespace": "off",
+      "@typescript-eslint/no-empty-object-type": "off",
+      "no-empty": ["error", { allowEmptyCatch: true }],
+    },
+  }
+);

package.json

@@ -15,7 +15,9 @@
     "dev": "pnpm build:evalite && pnpm build:evalite-ui && pnpm --filter evalite --filter evalite-tests --parallel run dev",
     "test": "pnpm build && pnpm --filter evalite --filter evalite-tests test",
     "example": "pnpm build && pnpm --filter example --filter evalite-ui --filter evalite --parallel dev",
-    "ci": "pnpm build && pnpm test && pnpm --filter evalite --filter evalite-tests lint && pnpm check-format",
+    "typecheck": "pnpm -r typecheck",
+    "lint": "eslint .",
+    "ci": "pnpm build && pnpm test && pnpm typecheck && pnpm lint && pnpm check-format",
     "docs:dev": "(cd apps/evalite-docs && pnpm run dev)",
     "release": "pnpm run build && changeset publish",
     "prepare": "husky",
@@ -39,7 +41,11 @@
     "typescript": "5.6.2"
   },
   "devDependencies": {
-    "lint-staged": "^16.2.4"
+    "@eslint/js": "^9.38.0",
+    "eslint": "^9.38.0",
+    "globals": "^16.4.0",
+    "lint-staged": "^16.2.6",
+    "typescript-eslint": "^8.46.2"
   },
   "lint-staged": {
     "*": "prettier --write --ignore-unknown"

packages/evalite-tests/package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "dev": "vitest -w",
     "test": "vitest run",
-    "lint": "tsc"
+    "typecheck": "tsc --noEmit"
   },
   "dependencies": {
     "evalite": "workspace:*",

packages/evalite-tests/tests/config.test.ts

@@ -1,4 +1,4 @@
-import { expect, it, vi } from "vitest";
+import { expect, it } from "vitest";
 import { getEvalsAsRecordViaStorage, loadFixture } from "./test-utils.js";
 
 it("Should ignore includes in a vite.config.ts", async () => {