expose frame execution context, url, name, and parent #185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes access to any frame's url, name, parent id, and both primary and secondary execution context ids stored in
Target
viaPage
and theTargetMessage
channel.Currently this is only possible by accessing
handler.targets()
directly (with the exception ofFrame.parent_frame
which isn't exposed at all outside of CDP methods), e.g.:(^ this feels a bit hacky for my liking.)
While I've included a few minor breaking changes (
TargetMessage::Url
, andPageInner.execution_context_for_world
), these don't appear to be usable outside of the crate, so the external API should remain stable.Please let me know if there are any changes you'd like me to make before merging, or if there's a simpler way of getting this information ;)