update state on update_protocol_request_interception #247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating protocol request interception we do not actual update the current state.
This causes a number of issues.
While supplying credentials via the page.authenticate() method, protocol interception is enabled. However the variable
protocol_request_interception_enabled
is never updated and remains false.During page visit the
on_fetch_request_paused
method is called. However the check whether we should continue with the request fails due toprotocol_request_interception_enabled
being false. The request never continues and times out.chromiumoxide/src/handler/network.rs
Lines 133 to 136 in 6f2392f