Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo to match command location and C Makefile target #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

djui
Copy link
Contributor

@djui djui commented Sep 29, 2011

No description provided.

@mattsta
Copy link
Owner

mattsta commented Sep 29, 2011

Is this commit right? The Makefile has:

 ../priv/stdin_forcer: stdin_forcer.c
      @mkdir -p ../priv
      $(CC) -Wall -Werror -pedantic -ansi -O2 -o ../priv/stdin_forcer stdin_forcer.c

Looks like changing the loader to get_base_dir(?MODULE) ++ "/priv/stdinout_forcer" would not find stdin_forcer.

@djui
Copy link
Contributor Author

djui commented Sep 29, 2011

Btw: maybe it's possible to use your project as library application, start it using application:start(stdinout) and then just use code:priv_dir(). Should make it cleaner.

@mattsta
Copy link
Owner

mattsta commented Sep 29, 2011

Good point about turning it into an application.

Maybe version 2.0 will be application + consistent naming + better worker pool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants