Explicitly stated what parameter caused the error #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the error would read, "Parameter cannot be less ... " but this is not helpful as it is too generic and could be from any of the parameters. I added name field to the function validate!(param, options, name) then it is called as validate!(params[name], options, name) inside the def param function since name is already supported there.
|
This would be nice addition. You may also want to update the spec, so that tests don't start failing: |
Author
|
@niekvenlo, good catch. I have updated the specs with the correct responses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the error would read, "Parameter cannot be less ... " but this is not helpful as it is too generic and could be from any of the parameters.
I added name field to the function validate!(param, options, name) then it is called as validate!(params[name], options, name) inside the def param function. The error message is updated inside the validation function as "The parameter #{name} ... "
since name is already supported there.