-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort and filters #104
Comments
I propose the sorting features by date and alphabetically from ascending to descending and vice versa. The filtering imho is a bit of harder to do - Yes, it can be done by using tags, but what exactly are those tags going to be so the filters won't get to noisy? Something like one-page, dark, light, sidebar, fixed-navigation etc? |
I agree about the filters. Really it would be up to the moderator/owner to manage the tags to keep things simple, so there would have to be buy in from him. |
sort by categories |
@nandomoreirame I'd be happy if You could contribute by making the sorting and filtering feature (You mentioned it in #204). My proposal is still the same as above:
The only thing is that I'd avoid JavaScript as much as possible, since the page should be usable also when JS is disabled. So if You could work out non-JS solution that would be really awesome. |
Since I'm not the lead for the project I'm not authorized to make huge changes in the repository (changing the layout is considered a major change). We have to wait @mattvh approval for this. I think that making search/filter for existing layout is fine. |
Proposed filters:
It is good to consider how to motivate or enforce theme authors to fill it. Maybe tests, so it will be visible in pull request if something is not filled? Also bigger screenshot helps (up to full screen, switch for size). |
Filtering/sorting by GitHub forks (not just stars) would be great as well. |
I would like this, too. As it is, the site is useless to me. I want to be able to search for themes that would work for my purpose structurally, then choose according to appearance. For example, I need theme to handle pages and sub pages, slide out menu. Then I would look at search results for right sidebar, dark background. Filtering by structure because floating a sidebar from left to right is easy compared to making a layout and _config file to work with it. Theme creators should also be able to add categories to filter by. |
@mattvh Would you be interested in an initial implementation and see if we/you can build from there? I am interested in contributing |
Thanks for this project, I find it really helpful.
Themes on your site are just ordered chronologically, have you thought about giving different sort options?
I imagine it would be possible to sort by number of GitHub stars using JavaScript.
The text was updated successfully, but these errors were encountered: