Integrate asset manager - Piler #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
This is again not a proper pull request and I don't expect it to be directly merged. Tests are not updated etc.
But anyway I integrated Piler with Zappa and I think it fits in very well as originally expected since many of the features in node-pile are originally inspired by Zappa :)
This would close issues #19, #79 and #94.
This changes the API for @client, @shared, @css and @stylus.
The API is now
If you omit the namespace it will default to global namespace in node-pile
Script and style tags are rendered with renderStyleTags and renderScriptTags helpers. The global namespace is always rendered and others can be added as arguments. See this example
There are some issues when serving build-in assets and I think this should be rethought if we really integrate this. @enable 'server jquery' style does not work so nicely with this. I have been thinking of adding support for ender-js for node-pile which could resolve this issue nicely.