Improve naming of anonymous classes & fix GitHub CI#103
Open
amousavigourabi wants to merge 2 commits intomauricioaniche:masterfrom
Open
Improve naming of anonymous classes & fix GitHub CI#103amousavigourabi wants to merge 2 commits intomauricioaniche:masterfrom
amousavigourabi wants to merge 2 commits intomauricioaniche:masterfrom
Conversation
Includes the method in which an anonymous class is defined in its name. Uses the format com.example.ClassImpl#method$Anonymous1 to replace com.example.ClassImpl$Anonymous1.
Owner
|
Hey, @amousavigourabi! Are you still going to work on this one? It's a good MR, I just need to understand the extra dependencies there. They don't seem necessary. Shall we just remove them and get this MR merged? |
Author
|
Hi @mauricioaniche ! It's been a while so I'm not 100% sure, but I believe that the pipeline failed without these dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aims to resolve (part of) #54 and make GitHub CI pass again.
Represents anonymous classes using the
com.example.ClassImpl#method$Anonymous1format.